fix: re-enable the spellchecker when new language list set #26119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
fast-track 🚅
MarshallOfSound
commented
Oct 22, 2020
| @@ -2,9 +2,19 @@ import * as childProcess from 'child_process'; | |||
| import * as path from 'path'; | |||
| import * as http from 'http'; | |||
| import * as v8 from 'v8'; | |||
| import { SuiteFunction, TestFunction } from 'mocha'; | |||
There was a problem hiding this comment.
This stuff I just added because it was annoying me, you can now do ifdescribe().only
Chromium recently added prefs logic to disable the spellchecker if the list of languages is empty, but the logic to re-enable if the languages are provided again lives in another part of Chromium. This change makes it so our API re-enables the spellchecker correctly when required.
MarshallOfSound
force-pushed
the
spellcheck-toggle-fix
branch
from
44bebb8
to
7528f2f
Compare
codebytere
approved these changes
Oct 22, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "11-x-y" cleanly; |
MarshallOfSound
added a commit
that referenced
this pull request
Oct 23, 2020
* fix: re-enable the spellchecker when new language list set Chromium recently added prefs logic to disable the spellchecker if the list of languages is empty, but the logic to re-enable if the languages are provided again lives in another part of Chromium. This change makes it so our API re-enables the spellchecker correctly when required. * chore: fix lint
|
@MarshallOfSound has manually backported this PR to "11-x-y", please check out #26129 |
MarshallOfSound
added a commit
that referenced
this pull request
Oct 23, 2020
* fix: re-enable the spellchecker when new language list set Chromium recently added prefs logic to disable the spellchecker if the list of languages is empty, but the logic to re-enable if the languages are provided again lives in another part of Chromium. This change makes it so our API re-enables the spellchecker correctly when required. * chore: fix lint
MarshallOfSound
added a commit
that referenced
this pull request
Oct 23, 2020
…26129) * fix: re-enable the spellchecker when new language list set Chromium recently added prefs logic to disable the spellchecker if the list of languages is empty, but the logic to re-enable if the languages are provided again lives in another part of Chromium. This change makes it so our API re-enables the spellchecker correctly when required. * chore: fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium recently added prefs logic to disable the spellchecker if the list of languages is empty, but the logic to re-enable if the languages are provided again lives in another part of Chromium. This change makes it so our API re-enables the spellchecker correctly when required.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2390300
Notes: Fixed issue where setting the spellchecker languages to an empty array would permanently disable the spellchecker till the end of time